Fix lookup_value_regex handling of non string types#1317
Draft
lotvall wants to merge 1 commit intotfranzel:masterfrom
Draft
Fix lookup_value_regex handling of non string types#1317lotvall wants to merge 1 commit intotfranzel:masterfrom
lotvall wants to merge 1 commit intotfranzel:masterfrom
Conversation
lotvall
force-pushed
the
integer-lookup-field-with-lookup-value-regex
branch
2 times, most recently
from
96a0a14 to
3911c55
Compare
lotvall
force-pushed
the
integer-lookup-field-with-lookup-value-regex
branch
from
3911c55 to
1c25019
Compare
lotvall
force-pushed
the
integer-lookup-field-with-lookup-value-regex
branch
from
1c25019 to
da20fdb
Compare
lotvall
commented
Oct 22, 2024
Comment on lines
-91
to
-94
| reverse_transforms=[ | ||
| lambda x: x.replace('format: uuid', 'pattern: ^[0-9]+$'), | ||
| lambda x: x.replace('\n description: A UUID string identifying this root.', '') | ||
| ] |
Author
There was a problem hiding this comment.
I didn't proceed with this, but it would be interesting here to keep this information for UUID's as well, as it would expose more correct information to Open API.
/root/{id}/:
get:
operationId: root_retrieve
parameters:
- in: path
name: id
schema:
type: string
format: uuid
description: A UUID string identifying this root.
required: true
Another approach that's adds pattern without removing format and description, but would be good to know if it's spec compliant:
schema:
type: string
format: uuid
pattern: [0-9]+
description: A UUID string identifying this root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around with a very naive fix for #1316
However I did run into some issues:
Breaking regression tests:
drf-spectacular/tests/test_regressions.py
Line 2430 in 0dea78c
And this test looks like it would be affected as well as it strips the UUID information:
drf-spectacular/tests/contrib/test_drf_nested_routers.py
Lines 91 to 94 in 0dea78c
I would be happy to proceed with this PR and make the solution robust, but any early feedback on the issue and advice on the regressions would be appreciated before proceeding!